-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ORCA version #3884
Update ORCA version #3884
Conversation
@TravisCarden we need to figure out why ORCA is scanning markdown files as if they were PHP, I assume this is due to a recent change in ORCA or coding standards? |
Yes, @danepowell. Acquia Coding Standards recently fixed an issue in acquia/coding-standards-php#1 where a bug in PHPCS was preventing Coder Sniffer from checking various file types it means to, including Markdown. This is a case of "fixing ours broke yours". :) But looking at your actual failures, you have a few "Expected 1 newline at end of file" that are valid. The only problem is ```php
$available_modules = system_rebuild_module_data();
$dependencies = array();
foreach ($available_modules as $name => $module) {
if ($module->info['package'] == 'My Bundle') {
$dependencies[] = $name;
}
\Drupal::service('module_installer')->install($dependencies);
}
``` |
Thanks a lot for the investigation and help, it seems to be working now. |
* Updated ORCA version. * added travis cache dir. * Fixed code style. * Fixed coding standards. * Fixed coding standards.
Changes proposed
Should have no functional impact, this is just improving ORCA integration and a follow up to Travis' PR here: #3882