Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ORCA version #3884

Merged
merged 6 commits into from
Oct 11, 2019
Merged

Update ORCA version #3884

merged 6 commits into from
Oct 11, 2019

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Oct 8, 2019

Changes proposed

Should have no functional impact, this is just improving ORCA integration and a follow up to Travis' PR here: #3882

@danepowell danepowell mentioned this pull request Oct 8, 2019
@danepowell
Copy link
Contributor Author

@TravisCarden we need to figure out why ORCA is scanning markdown files as if they were PHP, I assume this is due to a recent change in ORCA or coding standards?

@danepowell danepowell added 11.x Affects or applies to 11.x Backport needed PRs needing to be backported labels Oct 8, 2019
@TravisCarden
Copy link
Contributor

Yes, @danepowell. Acquia Coding Standards recently fixed an issue in acquia/coding-standards-php#1 where a bug in PHPCS was preventing Coder Sniffer from checking various file types it means to, including Markdown. This is a case of "fixing ours broke yours". :)

But looking at your actual failures, you have a few "Expected 1 newline at end of file" that are valid. The only problem is docs/configuration-management.md, and I think Coder Sniffer is incorrectly trying to check it because it's finding a PHP open tag (<?php) in it. I believe that's a bug, and I've reported it at Sniffer incorrectly applies PHP rules to non-PHP files if they contain PHP tags [#3086639]. I've confirmed that you can get around it by using code blocks with syntax highlighting, like this:

    ```php
    $available_modules = system_rebuild_module_data();
    $dependencies = array();
    foreach ($available_modules as $name => $module) {
      if ($module->info['package'] == 'My Bundle') {
        $dependencies[] = $name;
      }
      \Drupal::service('module_installer')->install($dependencies);
    }
    ```

@danepowell
Copy link
Contributor Author

Thanks a lot for the investigation and help, it seems to be working now.

@danepowell danepowell merged commit f083204 into acquia:11.x Oct 11, 2019
danepowell added a commit to danepowell/blt that referenced this pull request Oct 11, 2019
* Updated ORCA version.

* added travis cache dir.

* Fixed code style.

* Fixed coding standards.

* Fixed coding standards.
danepowell added a commit that referenced this pull request Oct 11, 2019
* Update ORCA version (#3884)

* Updated ORCA version.

* added travis cache dir.

* Fixed code style.

* Fixed coding standards.

* Fixed coding standards.

* Fixed code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.x Affects or applies to 11.x Backport needed PRs needing to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants