DT-948: Improve ACSF detection logic. #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
changed the title
alexxed
approved these changes
Oct 29, 2019
danepowell
added
11.x
danepowell
added a commit
that referenced
this pull request
Oct 29, 2019
* Improve ACSF detection logic. * Removed unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Steps to replicate the issue
01train1Previous (bad) behavior, before applying PR
Observe a BLT exception.
Expected behavior, after applying PR and re-running test steps
No exception, BLT correctly detects the presence of ACSF hosting
Additional details
The ACSF module itself just checks for the existence of the sites.json module, we should follow its lead (if that fails, BLT will be the least of the problem). Doing an additional regex is overkill and fails in some environments.
We considered alternatives such as checking the AH_REALM env var, but this is also not consistent between subscriptions (usually enterprise-g1, but sometimes other values). And again... let's just follow in the ACSF module's footsteps.