DT-950: Update node version in Pipelines. #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
added
Enhancement
adrianthedev
approved these changes
Oct 30, 2019
alexxed
reviewed
Oct 31, 2019
| @@ -18,7 +18,7 @@ events: | |||
| - composer validate --no-check-all --ansi | |||
| - composer install --ansi | |||
| - source ${BLT_DIR}/scripts/pipelines/setup_env | |||
| # - nvm install v6.9.1 | |||
| # - nvm install v6.9.1 --latest-npm | |||
There was a problem hiding this comment.
are you updating node version or npm version ?
nvm install lts/* installs the latest lts for example
There was a problem hiding this comment.
oh, it's a comment :D doh!
alexxed
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3900
Changes proposed
Requires change record since users relying on BLT's node version might be surprised when it goes away.