DT-1016: BLT 10.x tests broken. #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianthedev
approved these changes
Dec 3, 2019
alexxed
approved these changes
Dec 4, 2019
danepowell
added a commit
that referenced
this pull request
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLT's internal tests mirror
subtree-splits/blt-require-devto/tmp/blt-require-devand then add it as a Composer local path repository.The problem is that
/tmp/blt-require-devhas no specific version or Git history, so Composer interprets its version asdev-master. When you have a newer or more stable version (such as the recently-released 11.0.0-alpha1) Composer might use that instead of the local version, breaking tests.Incidentally, it's pretty frustrating and confusing how Composer handles this. I don't know why it suddenly decided to use the new release instead of the local version.
composer why-not acquia/blt-require-dev:dev-masterrevealsThere is no installed package depending on "acquia/blt-require-dev" in versions not matching dev-master, which I think is Composer's way of saying "Oh yeah I'd be happy to install the local version for you", and yet... it doesn't. 🤷♂️Additionally, it appears to be "sticky"... if you do install the local version using
dev-masteras the version constraint, and then change the constraint back to*@devand runcomposer update, Composer will keep the local version... even though it would get the remote package in a fresh-install scenario with the same composer.json.