DT-981: Fixes #3921: Enabled D9 deprecated code scanning by default.

[danepowell]

Fixes #3921

Changes proposed

• Enable deprecated code scanning of custom modules and themes by default. Note that this will not apply if a user has manually overridden this via blt.yml.

Steps to replicate the issue

1. Run blt validate
2. Ensure that tests:deprecated:modules and tests:deprecated:themes are run automatically as part of the tests.

[jedgar1mx]

This is throwing an error during my build, is there a way to temporary bypass them?
THanks

[danepowell]

@jedgar1mx the process for disabling scanning is described in the BLT 11 release notes.

If you read that already and it wasn't clear, let me know how we could improve it.

If you haven't read that already, you really should 😄

[jedgar1mx]

Hi Dane, I totally missed that note. Since I followed the steps on the 11.0.0-rc1 release I ignored these. Thanks for all the help

…

On Tue, Dec 17, 2019 at 1:54 PM Dane Powell ***@***.***> wrote: @jedgar1mx <https://github.com/jedgar1mx> the process for disabling scanning is described in the BLT 11 release notes <https://support.acquia.com/hc/en-us/articles/360039081454#d9deprecatedcodescanningenabledbydefault> . If you read that already and it wasn't clear, let me know how we could improve it. If you haven't read that already, you really should 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3946?email_source=notifications&email_token=AFA26Q3S2Z5JTQQXIVLPQU3QZEN4NA5CNFSM4JZEGVMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHDSIJQ#issuecomment-566699046>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFA26Q442EXM2SBZD7VZEILQZEN4NANCNFSM4JZEGVMA> .

[Luukyb]

Hi,
I arrived on this PR from the release notes of BLT 11.x. It was a bit difficult for me to find out how to disable the depreciation tests. I first was looking at "disable-targets" but it has to be in "validate". I will just share what I added in my blt.yml if that can help someone else:

validate:
  deprecation:
    modules: false
    themes: false

Thanks,
Luc