Fixes #3994: Get environment detector subclass results on bootstrap. #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
commented
Feb 19, 2020
| return []; | ||
| } | ||
| $autoloader = require DRUPAL_ROOT . '/autoload.php'; | ||
| $autoloader = require self::getRepoRoot() . '/vendor/autoload.php'; |
There was a problem hiding this comment.
DRUPAL_ROOT isn't the same as self::getRepoRoot() . '/vendor' but that's okay since Drupal's autoload.php is just a wrapper for the root autoloader.
|
i'll give it a whirl and let you know. |
|
@danepowell i tested this in Azure Pipelines vs. the previous PR I had submitted and thing seem to work fine on that end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3994
Changes proposed
Additional details
This feels a little hacky, I hate relying on a global variable like
$repo_rootbut I don't know of a better solution since that variable is literally the first one set when you invoke BLT (before the autoloader is even loaded), so I'm not sure how we could store it in a more encapsulated way.