Fixes #4229: Stop modifying local db name for ACSF #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
added
12.x
mikemadison13
pushed a commit
to mikemadison13/blt
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4229
Motivation
This conditional does nothing meaningful because the environment detector has no way to find the ACSF db name locally, but it does cause confusion by adding extra characters to the db name.
Proposed changes
This doesn't fully restore dynamic db support for local ACSF apps, but it at least fixes the confusing behavior. Adding full support for multiple ACSF dbs OOTB is a perennial challenge, because we have no way to determine ACSF db names locally unless they are hardcoded somewhere. In BLT 11, this was hardcoded in
multisiteconfig but this is a bad solution since it adds 100s of ms to each page request (to bootstrap the config loader).