Fixes #4275: Cannot run Yaml validator multiple times #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4275
Proposed changes
Use this reset parameter for the Yaml validator so that subsequent runs don't contaminate each other.
Testing steps
Follow steps in #4275 . Verify that only the first Yaml error is reported.
Steps to verify the solution
Same as above, but verify that errors in both files are reported all ten times.
An upstream issue (symfony/symfony#8871) indicates this is a common problem and offers alternative solutions, but this one is what has been implemented for the
TwigCommandand in addition has been already implemented in v10.x.