Fix #4375: Swap EnvironmentDetector to use new loophp/phposinfo #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergr
changed the title
|
Test failure seems like an upstream bug, seeing if re-running the test fixes it (need loophp/osinfo ^1.7): loophp/phposinfo@d4cda34 |
|
Well, sadly the loophp/phposinfo 1.6.5 namespaces are borked, and 1.7.0 requires PHP 7.4. This puts us in quite a tough spot. Upstream issue: loophp/phposinfo#1 |
|
Fixed in https://github.com/loophp/phposinfo/releases/tag/1.7.1 ! Sorry about this!!! |
|
Thanks for the PR, and for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4375
Proposed changes
Update the
src/Robo/Common/EnvironmentDetector.phpto use the newloophp/phposinfoinstead of the abandoneddrupol/phposinfoTesting steps
composer update acquia/blt --with-all-dependencesand confirm no errorsMerge requirements