Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-1890: Validate new DRS plugin with BLT #4709

Merged
merged 11 commits into from
Mar 28, 2024
Merged

ACMS-1890: Validate new DRS plugin with BLT #4709

merged 11 commits into from
Mar 28, 2024

Conversation

chandan-singh7929
Copy link
Contributor

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

@rajeshreeputra
Copy link

Screenshot 2023-11-20 at 11 15 07 AM When upgraded the BLT to dev-ACMS-1890 version it requires the DRS plugin automatically and writes to the settings.php file. Screenshot 2023-11-20 at 11 16 38 AM This should not happen if there BLT/DRS settings file require link is available.

Copy link

@rajeshreeputra rajeshreeputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look

src/Robo/Commands/Blt/MigrateToDrsCommand.php Show resolved Hide resolved
composer.json Show resolved Hide resolved
Copy link

@rajeshreeputra rajeshreeputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good, added minor feedback, please have look at it.

tests/packages_alter.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@chandan-singh7929
Copy link
Contributor Author

Screenshot 2023-11-20 at 11 15 07 AM When upgraded the BLT to dev-ACMS-1890 version it requires the DRS plugin automatically and writes to the settings.php file. Screenshot 2023-11-20 at 11 16 38 AM This should not happen if there BLT/DRS settings file require link is available.

Done

@chandan-singh7929 chandan-singh7929 marked this pull request as ready for review March 28, 2024 13:08
@danepowell danepowell merged commit 5538f36 into acquia:main Mar 28, 2024
6 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants