Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLT-5237: Fix failing PHPUnit tests. #4747

Merged
merged 1 commit into from
Apr 3, 2024
Merged

BLT-5237: Fix failing PHPUnit tests. #4747

merged 1 commit into from
Apr 3, 2024

Conversation

vishalkhode1
Copy link
Contributor

No description provided.

@danepowell
Copy link
Contributor

It's a little hard to tell, but I think it's actually a problem with recommended-settings tests killing the integrated test:

PHP Fatal error:  Uncaught Error: Class "Acquia\Drupal\RecommendedSettings\Tests\FunctionalTestBase" not found in /home/runner/work/blt/orca-build/vendor/acquia/drupal-recommended-settings/tests/src/Functional/Config/ConfigInitializerTest.php:17

I don't understand what would cause that since the class seems to exist in DRS 1.0.0 as expected.

@vishalkhode1 vishalkhode1 marked this pull request as ready for review April 3, 2024 08:22
@vishalkhode1
Copy link
Contributor Author

It's a little hard to tell, but I think it's actually a problem with recommended-settings tests killing the integrated test:

PHP Fatal error:  Uncaught Error: Class "Acquia\Drupal\RecommendedSettings\Tests\FunctionalTestBase" not found in /home/runner/work/blt/orca-build/vendor/acquia/drupal-recommended-settings/tests/src/Functional/Config/ConfigInitializerTest.php:17

I don't understand what would cause that since the class seems to exist in DRS 1.0.0 as expected.

Should be good now. The above error is coming on acquia/drupal-recommended-settings plugin as well and it's due to a bug in ORCA and we've resolved it by creating a patch for it. See this.
The same error was coming on BLT becaus we've updated packages_alter.yml file in last PR and forgot to remove later.

@danepowell danepowell merged commit e273171 into acquia:main Apr 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants