Update default PHP version to 7.3 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TravisCarden the test failures are because drupal/coder updated. That's why I put the composer update in a separate commit. Are you able to update Coder and fix the style issues in a separate PR, and then I can update this one? |
TravisCarden
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Thanks, @danepowell. A couple of changes needed. Note to self: we should document minimum requirements sometime. (That's not requested for this PR.)
TravisCarden
approved these changes
Oct 20, 2020
TravisCarden
pushed a commit
that referenced
this pull request
Nov 16, 2020
TravisCarden
pushed a commit
to TravisCarden/orca
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be done in sync with acquia/coding-standards-php#15
We explicitly base our PHP version on that recommended by Acquia and Drupal (see links in example/.travis.yml).
Drupal now recommends PHP 7.3, and Acquia has removed PHP 7.2 from the Cloud platform. PHP 7.2 itself is EOL in one month.
Let's go ahead and make PHP 7.3 the standard for ORCA.