Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static analysis tests #558

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix static analysis tests #558

merged 1 commit into from
May 24, 2024

Conversation

secretsayan
Copy link
Contributor

No description provided.

@secretsayan secretsayan added the bug Something isn't working label May 23, 2024
@TravisCarden
Copy link
Contributor

You definitely don't need my review on something this simple, @secretsayan. In a case like this, if the tests pass, go ahead. 🙂

@secretsayan
Copy link
Contributor Author

You definitely don't need my review on something this simple, @secretsayan. In a case like this, if the tests pass, go ahead. 🙂

I wanted to show you, how phpunit 10 is breaking our simplest tests :(

@TravisCarden
Copy link
Contributor

Okay. Then is there something you need from me?

@secretsayan
Copy link
Contributor Author

Okay. Then is there something you need from me?

If you don't have any comments/suggestions, I will just merge it.

@TravisCarden
Copy link
Contributor

No, no concerns. In fact, it seems better this way. I assume static analysis complained because of duplicate keys, which are a genuine issue to be fixed. Also, the arrays now reflect the names of the test method arguments. So it seems better all around.

@secretsayan secretsayan merged commit 2a82743 into acquia:develop May 24, 2024
43 of 44 checks passed
@secretsayan
Copy link
Contributor Author

No, no concerns. In fact, it seems better this way. I assume static analysis complained because of duplicate keys, which are a genuine issue to be fixed. Also, the arrays now reflect the names of the test method arguments. So it seems better all around.

Okay, then merging

@secretsayan secretsayan deleted the fix-static-analysis branch May 24, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisCarden TravisCarden Awaiting requested review from TravisCarden

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@secretsayan @TravisCarden