SFSDK-7 Adds a delete and codebase endpoints #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgregory
changed the title
bnagykekesi
reviewed
Sep 7, 2017
lib/sfrest/codebase.rb
Outdated
| @@ -0,0 +1,16 @@ | |||
| module SFRest | |||
| # List codebases on the | |||
bnagykekesi
reviewed
Sep 7, 2017
lib/sfrest/codebase.rb
Outdated
| end | ||
|
|
||
| # Lists the codebases | ||
| # @return [Hash] A hash of codebases configured for the factory |
bnagykekesi
reviewed
Sep 7, 2017
lib/sfrest/site.rb
Outdated
| @@ -83,13 +83,28 @@ def site_list | |||
| # @param [String] sitename The name of the site to create | |||
| # @param [Integer] group_id The Id of the group the site is to be a member of | |||
| # @param [String] install_profile The install profile to use when creating the site | |||
| def create_site(sitename, group_id, install_profile = nil) | |||
| def create_site(sitename, group_id, install_profile = nil, codebase = nil) | |||
bnagykekesi
reviewed
Sep 7, 2017
lib/sfrest/site.rb
Outdated
| # @param [String] sitename The name of the site to create | ||
| # @param [Integer] group_id The Id of the group the site is to be a member of | ||
| # @param [String] install_profile The install profile to use when creating the site | ||
| alias create create_site |
bnagykekesi
reviewed
Sep 7, 2017
spec/site_spec.rb
Outdated
| site_id = site_data['site_id'] | ||
| site_name = site_data['site'] | ||
| task_id = site_data['task_id'] | ||
| it 'can create a site' do |
- add params for codebase in create - fix incorrect name in site delete spec - missing punctuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.