Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<h1> headings are non-interactive but have cursor:pointer #54

Closed
patrickhlauke opened this issue Nov 7, 2019 · 0 comments · Fixed by #73
Closed

<h1> headings are non-interactive but have cursor:pointer #54

patrickhlauke opened this issue Nov 7, 2019 · 0 comments · Fixed by #73

Comments

@patrickhlauke
Copy link
Contributor

as all heading levels get styles from the header-style mixin https://github.com/act-rules/act-rules-web/blob/master/src/styles/mixins.scss and that mixin includes cursor: pointer;, <h1> headings - which are non-interactive/do not contain anything clickable (compared to, say, most <h2>s that, when hovered, show the anchor/link to that particular section) - confusingly appear to be clickable when they're not.

screenshot showing the hand cursor when hovering over an h1
@patrickhlauke patrickhlauke changed the title <h1> headings are non-interactive but have cursor:pointer <h1> headings are non-interactive but have cursor:pointer Nov 7, 2019
This was referenced Nov 20, 2019
Open
Closed
patrickhlauke added a commit to patrickhlauke/act-rules-web that referenced this issue Nov 21, 2019
@patrickhlauke
Remove cursor:pointer from header-style mixin
5489906 
While it's true that most elements that use this mixin are also interactive, it is also used on static elements ... and here, having the explicit `cursor:pointer` mouse cursor (the "hand" one) is misleading and confusing, as it makes those static elements appear to be interactive/clickable to sighted mouse users.

Closes act-rules#54
Closes act-rules#69
@patrickhlauke patrickhlauke mentioned this issue Nov 21, 2019
Merged
jeeyyy pushed a commit that referenced this issue Nov 21, 2019
@patrickhlauke @jeeyyy
fix: Remove cursor:pointer from header-style mixin (#73)
2a058f7 
While it's true that most elements that use this mixin are also interactive, it is also used on static elements ... and here, having the explicit `cursor:pointer` mouse cursor (the "hand" one) is misleading and confusing, as it makes those static elements appear to be interactive/clickable to sighted mouse users.

Closes #54
Closes #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove cursor:pointer from header-style mixin patrickhlauke/act-rules-web
1 participant
@patrickhlauke