-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon layers #479
Icon layers #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge improvement! Crossings would be good too. We need upstream work in data-prep to detect zebras and other things better, so maybe should do that first. Signalized, zebra, other?
assets/train.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks like a weird squished gondola or something to me, personally. Even though not all stations are National Rail, how do you feel about using https://en.wikipedia.org/wiki/File:National_Rail_logo.svg? It's quite recognizable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah I was experimenting then didn't revert, will remove
import OsmLicense from "../OsmLicense.svelte"; | ||
|
||
let name = "cycle_parking"; | ||
let color = colors.cycle_parking; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can clean up some entries in colors
now \o/
|
||
let show = false; | ||
</script> | ||
|
||
<Checkbox bind:checked={show}> | ||
<ColorLegend {color} /> | ||
<img src={cycleParking} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs alt
@@ -31,6 +29,9 @@ | |||
</ExternalLink> (as of 9 August 2023). The type of parking, public/private | |||
access, and whether it's covered are not shown. | |||
</p> | |||
<p> | |||
Icon from <a href="https://github.com/gravitystorm/openstreetmap-carto?tab=License-1-ov-file#readme">OpenStreetMap Carto</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just https://github.com/gravitystorm/openstreetmap-carto as a link is fine
layout={{ | ||
"icon-image": "cycle_parking", | ||
"icon-size": 1.0, | ||
"icon-allow-overlap": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of this for both. It looks kind of messy at low zoom, but having icons appear as you zoom in is really disorienting to me
@@ -31,24 +28,28 @@ | |||
railway station | |||
</ExternalLink> data from OpenStreetMap (as of 9 August 2023). | |||
</p> | |||
<p> | |||
Icon from <a href="https://iconduck.com/sets/font-awesome-icons"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated
assets/train.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: train is a weird name, maybe railway_station.png
just to match up with the layer?
No description provided.