Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon layers #479

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Icon layers #479

merged 6 commits into from
Feb 26, 2024

Conversation

Pete-Y-CS
Copy link
Contributor

No description provided.

Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge improvement! Crossings would be good too. We need upstream work in data-prep to detect zebras and other things better, so maybe should do that first. Signalized, zebra, other?

assets/train.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks like a weird squished gondola or something to me, personally. Even though not all stations are National Rail, how do you feel about using https://en.wikipedia.org/wiki/File:National_Rail_logo.svg? It's quite recognizable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't seem to help the gradient case much:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I was experimenting then didn't revert, will remove

import OsmLicense from "../OsmLicense.svelte";

let name = "cycle_parking";
let color = colors.cycle_parking;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can clean up some entries in colors now \o/


let show = false;
</script>

<Checkbox bind:checked={show}>
<ColorLegend {color} />
<img src={cycleParking} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs alt

@@ -31,6 +29,9 @@
</ExternalLink> (as of 9 August 2023). The type of parking, public/private
access, and whether it's covered are not shown.
</p>
<p>
Icon from <a href="https://github.com/gravitystorm/openstreetmap-carto?tab=License-1-ov-file#readme">OpenStreetMap Carto</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just https://github.com/gravitystorm/openstreetmap-carto as a link is fine

layout={{
"icon-image": "cycle_parking",
"icon-size": 1.0,
"icon-allow-overlap": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this for both. It looks kind of messy at low zoom, but having icons appear as you zoom in is really disorienting to me

@@ -31,24 +28,28 @@
railway station
</ExternalLink> data from OpenStreetMap (as of 9 August 2023).
</p>
<p>
Icon from <a href="https://iconduck.com/sets/font-awesome-icons">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated

assets/train.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: train is a weird name, maybe railway_station.png just to match up with the layer?

@Pete-Y-CS Pete-Y-CS changed the title WIP:Icon layers Icon layers Feb 23, 2024
@Pete-Y-CS Pete-Y-CS merged commit 00fc4dd into main Feb 26, 2024
2 checks passed
@Pete-Y-CS Pete-Y-CS deleted the icon-layers branch February 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants