Indicate the side of road for pavement width #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pete-Y-CS
reviewed
May 16, 2024
| @@ -82,27 +108,33 @@ | |||
| visibility: show ? "visible" : "none", | |||
| }} | |||
| > | |||
| <Popup let:props> | |||
| <Popup let:props openOn="hover"> | |||
| {#if props.left_average} | |||
There was a problem hiding this comment.
My overzealous DRY instincts are kicking in, is it overkill to turn this into its own component rather than having mostly the same code for both left and right?
Pete-Y-CS
approved these changes
May 16, 2024
|
new pmtiles uploaded |
|
Refactored the popups, but noticed the directions are wrong. There are 8 directions, 360/8 is 45, but north shouldn't be 0 to 45, it should be split to handle 360 - 45/2, and so on. Does that make sense? It's late, can pick up next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs the new pmtiles, of course