Bug fixes to #718 #725
Merged
Bug fixes to #718 #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elireisman
reviewed
Mar 22, 2024
| const parts = packageName.split('/') | ||
| repositoryUrl = `github.com/${parts[0]}/${parts[1]}` // e.g. github.com/actions/checkout | ||
| } | ||
|
|
There was a problem hiding this comment.
🤔 nit: would be good to explicitly check this output in the new test case?
There was a problem hiding this comment.
Hmm, the repositoryUrl isn't exposed outside of the function. Thoughts on how to bootstrap that into the tests? Was trying to avoid side effects on the Change object by using a local variable.
There was a problem hiding this comment.
Sorry late getting back to this. May the easiest play is to factor out 21-26 into a function that accepts a Change and outputs a repositoryUrl (or not) that line 29 can check, then test that in isolation with some Actions-flavored Changes?
Again not the end of the world, since it's already landed 👍
elireisman
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718
This pull request addresses the handling of GitHub Actions in the
scorecard.tsandscorecard.test.tsfiles. The changes include the addition of a special case for GitHub Actions in thegetScorecardLevelsfunction, modification of theapiRootURL, and the addition of new tests to verify these changes.