Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default runtime to node16 #235

Merged
merged 1 commit into from Feb 9, 2022
Merged

Update default runtime to node16 #235

merged 1 commit into from Feb 9, 2022

Conversation

thboop
Copy link
Contributor

@thboop thboop commented Feb 7, 2022

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12. 

This is supported on all Actions Runners v2.285.0 or later.
@thboop thboop requested a review from as a code owner Feb 7, 2022
@jclem
Copy link
Collaborator

@jclem jclem commented Feb 7, 2022

Looks good to me. cc @joshmgross do you think this warrants a major version bump of the action itself? e.g. out-dated self-hosted runners, etc.

@joshmgross
Copy link
Member

@joshmgross joshmgross commented Feb 7, 2022

This is effectively a breaking change as we'll now be running users' scripts with Node 16 instead of Node 12, so it will require a major version update.

If we're bumping the major version, I'd love to see if we can fit #168 into that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants