Unable to use command line winxp component

[romanholidaypancakes]

Description

Unable to use command line winxp component, everything worked fine 3 days ago.
If possible, please allow the xp component to exist by default.

Platforms affected

• Azure DevOps
• GitHub Actions

Virtual environments affected

• Ubuntu 18.04
• Ubuntu 20.04
• Ubuntu 22.04
• macOS 10.15
• macOS 11
• macOS 12
• Windows Server 2019
• Windows Server 2022

Image version and build link

https://github.com/inaryart/test-actions/runs/7805719506?check_suite_focus=true

Is it regression?

na

Expected behavior

Can successfully install xp components

Actual behavior

Failed to install xp components

Repro steps

• local machine
  If you have enterprise version vs2022 on your machine you can successfully install xp components using following command:

"C:\Program Files (x86)\Microsoft Visual Studio\Installer\setup.exe" modify --add "Microsoft.VisualStudio.Component.WinXP" --installpath="C:\Program Files\Microsoft Visual Studio\2022\Enterprise" --quiet

Then use the following command dir C:\ProgramData\Microsoft\VisualStudio\Packages to find

Microsoft.Windows.XPSupport.Msi.versionxxxxxxxxxxxxxxxxx

• github actions

If executing the same command in github actions does not install correctly

# This is a basic workflow to help you get started with Actions

name: CI

# Controls when the workflow will run
on:
  # Triggers the workflow on push or pull request events but only for the "main" branch
  push:
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]

  # Allows you to run this workflow manually from the Actions tab
  workflow_dispatch:

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
  # This workflow contains a single job called "build"
  build:
    # The type of runner that the job will run on
    runs-on:  windows-2022

    # Steps represent a sequence of tasks that will be executed as part of the job
    steps:
      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
      - uses: actions/checkout@v3
      - name: Run a multi-line script
        shell: cmd
        run: |
          attrib "C:\Program Files (x86)\Microsoft Visual Studio\Installer\setup.exe"
          "C:\Program Files (x86)\Microsoft Visual Studio\Installer\setup.exe" modify --add "Microsoft.VisualStudio.Component.WinXP" --installpath="C:\Program Files\Microsoft Visual Studio\2022\Enterprise" --quiet
           dir C:\ProgramData\Microsoft\VisualStudio\Packages

[igorboskovic3]

Hi @inaryart, thank you, we will take a look.

[al-cheb]

Hey @inaryart.

I am not able to reproduce the issue:

runs-on: windows-2022
    steps:
      - run: |
          Set-Location "C:\Program Files (x86)\Microsoft Visual Studio\Installer\"
          $InstallPath = "C:\Program Files\Microsoft Visual Studio\2022\Enterprise"
          $componentsToAdd = @(
            "Microsoft.VisualStudio.Component.WinXP"
          )
          [string]$workloadArgs = $componentsToAdd | ForEach-Object {" --add " +  $_}
          $Arguments = ('/c', "vs_installer.exe", 'modify', '--installPath', "`"$InstallPath`"",$workloadArgs, '--quiet', '--norestart', '--nocache')
          $process = Start-Process -FilePath cmd.exe -ArgumentList $Arguments -Wait -PassThru -WindowStyle Hidden
          if ($process.ExitCode -eq 0)
          {
              Write-Host "components have been successfully added"
              Get-ChildItem C:\ProgramData\Microsoft\VisualStudio\Packages\Microsoft.Windows.XPSupport.*
          }
          else
          {
              Write-Host "components were not installed"
              exit 1
          }

[romanholidaypancakes]

@al-cheb you can check this link of mine, it is not installed
https://github.com/inaryart/test-actions/runs/7805719506?check_suite_focus=true

[al-cheb]

@al-cheb you can check this link of mine, it is not installed https://github.com/inaryart/test-actions/runs/7805719506?check_suite_focus=true

Were you able to reproduce the issue with my code snippet above?

[romanholidaypancakes]

@al-cheb you can check this link of mine, it is not installed https://github.com/inaryart/test-actions/runs/7805719506?check_suite_focus=true

Were you able to reproduce the issue with my code snippet above?

winxp is not installed, check this:
https://github.com/inaryart/test-actions/runs/7806411425?check_suite_focus=true

[al-cheb]

@al-cheb you can check this link of mine, it is not installed https://github.com/inaryart/test-actions/runs/7805719506?check_suite_focus=true

Were you able to reproduce the issue with my code snippet above?

winxp is not installed, check this: https://github.com/inaryart/test-actions/runs/7806411425?check_suite_focus=true

Could you please use my code snippet that I mentioned in #6067 (comment) ?

[romanholidaypancakes]

@al-cheb you can check this link of mine, it is not installed https://github.com/inaryart/test-actions/runs/7805719506?check_suite_focus=true

Were you able to reproduce the issue with my code snippet above?

winxp is not installed, check this: https://github.com/inaryart/test-actions/runs/7806411425?check_suite_focus=true

Could you please use my code snippet that I mentioned in #6067 (comment) ?

test xp 2 is your test code

/test-actions/blob/b42ccc29b91862c243c59b32d57f56461ecc57d2/.github/workflows/blank.yml

[al-cheb]

.WinXP

Please remove test xp 1

[romanholidaypancakes]

Well, it seems to be installed
https://github.com/inaryart/test-actions/runs/7806610068?check_suite_focus=true

[romanholidaypancakes]

Maybe this issues can be closed? (It's up to you guys)
in fact, three days ago I was sure that my command could install the winxp components. I just noticed an update windows-2022.