Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove choco alias cpack.exe that conflicts with CMake cpack #651

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Remove choco alias cpack.exe that conflicts with CMake cpack #651

merged 1 commit into from
Apr 3, 2020

Conversation

al-cheb
Copy link
Contributor

@al-cheb al-cheb commented Apr 1, 2020

Description

There are two cpack.exe in PATH

  1. The alias of choco pack for Chocolatey
  2. The pack module of the CMake suite

The first one (placed in %ChocolateyInstall%\bin\) is in front of the second one (%ProgramFiles%\CMake\bin\), so when use cpack, it will call the %ChocolateyInstall%\bin\cpack.exe . But actually, the %ChocolateyInstall%\bin\cpack.exe is just an alias, while %ProgramFiles%\CMake\bin\cpack.exe is an important program, and the second one is more important the the first one.

chocolatey/choco@e9dcb0c

NOTE: `cpack` has been deprecated as it has a name collision with CMake. Please 
 use `choco pack` instead. The shortcut will be removed in v1.

Related issue:

#649
chocolatey/choco#89

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Copy link
Contributor

@sergey-akhalkov sergey-akhalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 👍

Should we worry about regression?

@gep13
Copy link

gep13 commented Apr 1, 2020

@sergey-akhalkov said...
Should we worry about regression?

It is possible that some folks might be using cpack in some of their builds, so this might cause a problem. Most of the documentation in our Chocolatey docs suggests that folks should use choco pack when building, so we are encouraging folks to do this, but there are likely some that still do it.

Copy link

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alepauly alepauly merged commit cf8323f into actions:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants