Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runner-package to curated images #8474

Merged

Conversation

pshepherd10
Copy link
Contributor

@pshepherd10 pshepherd10 commented Oct 5, 2023

Description

The plan is to cache the runner package onto our curated images just in case the CDN that we use to download the package is experiencing downtime. This will help speed up VM setup times in some cases when the latest version is already cached.

The size of the package on linux would be 180Mb and windows would be 84Mb.
Related:
ADR
https://github.com/github/actions-larger-runners/issues/2318

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@pshepherd10 pshepherd10 changed the title add runner-package to linux images add runner-package to curated images Oct 5, 2023
@pshepherd10 pshepherd10 marked this pull request as ready for review October 24, 2023 17:29
maxim-lobanov
maxim-lobanov previously approved these changes Oct 24, 2023
@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mikhailkoliada
Copy link
Contributor

@pshepherd10 please make a separate pr for windows

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pshepherd10
Copy link
Contributor Author

/azp run ubuntu2004,ubuntu2204

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8474 in repo actions/runner-images

@pshepherd10
Copy link
Contributor Author

@mikhailkoliada Are those image build failures related to mine? Can we try rerunning them?

@mikhailkoliada
Copy link
Contributor

@pshepherd10 actually I was thinking, lets introduce the test on both windows and ubuntu runners to make sure that the runner directory exist and not empty

@pshepherd10
Copy link
Contributor Author

@mikhailkoliada ok just added the test, let me know if that is right.

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

@mikhailkoliada
Copy link
Contributor

@pshepherd10 hmm you might need use sudo before the mkdir call

@pshepherd10
Copy link
Contributor Author

@mikhailkoliada ok added sudo lets see if that works

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pshepherd10
Copy link
Contributor Author

@mikhailkoliada I'm not sure if this is why its failing but the filter I have for getting the download url isn't good since there are multiple .tar.gz endings. I think test("actions-runner-linux-x64-[0-9].[0-9]{3}.[0-9].tar.gz") might be better since it uses regex and looks for an exact match.

@pshepherd10
Copy link
Contributor Author

https://jqplay.org/s/qYBTIZGg_lV looks like it should work

@pshepherd10
Copy link
Contributor Author

fixed more syntax issues

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pshepherd10
Copy link
Contributor Author

@mikhailkoliada Not sure why it's still failing. I changed the install order for the packages so we don't have to wait an hour to check if it passes.

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Co-authored-by: Erik Bershel <110455084+erik-bershel@users.noreply.github.com>
@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mikhailkoliada mikhailkoliada merged commit 25a3a04 into actions:main Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants