Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Implement new directories hierarchy #8616

Merged

Conversation

vpolikarpov-akvelon
Copy link
Contributor

@vpolikarpov-akvelon vpolikarpov-akvelon commented Oct 20, 2023

Description

This PR implements new unified directories hierarchy for Windows image source code:

  • assets: Configuration files that are copied to the image during the build process.
    • post-gen: Scripts and files related to post-image generation tasks.
  • scripts:
    • build: Scripts that are executed during the image build process.
    • helpers: Scripts used by other scripts during the image build process.
    • docs-gen: Script and PowerShell modules for generating software and configuration reports.
    • tests: Test scripts and related files for validating the image.
  • templates: Packer templates for the image build process.
  • toolsets: JSON files that define the software versions to be installed on the image.

⚠️
Packer templates are moved to templates directory and renamed.
Pipelines that reference them will need an update

Related issue: https://github.com/actions/runner-images-internal/issues/5513

CI Runs: Windows 2019, Windows 2022

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@vpolikarpov-akvelon vpolikarpov-akvelon marked this pull request as ready for review October 20, 2023 11:47
@vpolikarpov-akvelon vpolikarpov-akvelon force-pushed the windows-new-dir-hierarchy branch 3 times, most recently from b95b81f to 68a949e Compare October 20, 2023 13:37
@shamil-mubarakshin
Copy link
Contributor

shamil-mubarakshin commented Oct 23, 2023

windows2019.yml and windows2022.yml labeled trigger needs update as well

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to style guide: "Each file should have a newline at the end;"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only updates directory structure. Refactoring of script themselves will be performed later via separate request.

@mikhailkoliada mikhailkoliada merged commit d1f2c9a into actions:main Nov 15, 2023
3 checks passed
entvex pushed a commit to entvex/runner-images that referenced this pull request Nov 15, 2023
@vpolikarpov-akvelon vpolikarpov-akvelon deleted the windows-new-dir-hierarchy branch November 16, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants