Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Adjust services handling in Finalize-VM and helpers #8771

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[Windows] Adjust services handling in Finalize-VM and helpers #8771

merged 1 commit into from
Nov 10, 2023

Conversation

shamil-mubarakshin
Copy link
Contributor

@shamil-mubarakshin shamil-mubarakshin commented Nov 9, 2023 •
edited
Loading

Description

This PR:

  1. Switches to Stop-SvcWithErrHandling and Set-SvcWithErrHandling functions in Finalize-VM.ps1.
  2. Adds StopOnError parameter to Set-SvcWithErrHandling function.
  3. Adjusts Stop-SvcWithErrHandling and Set-SvcWithErrHandling functions to style guide.

Related issue: #8770

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@shamil-mubarakshin shamil-mubarakshin marked this pull request as ready for review November 10, 2023 09:32
@mikhailkoliada
Copy link
Contributor

/azp run windows2019,windows2022

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mikhailkoliada mikhailkoliada merged commit 495f740 into actions:main Nov 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailkoliada mikhailkoliada mikhailkoliada approved these changes

Assignees
No one assigned
Labels
CI windows-all
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamil-mubarakshin @mikhailkoliada