Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable SSH port #9660

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Configurable SSH port #9660

merged 1 commit into from
Apr 9, 2024

Conversation

paveliak
Copy link
Contributor

@paveliak paveliak commented Apr 8, 2024

Description

This PR adds an option to specify SSH port for the null builder (defaults to 22).

It also switches null builder to using public key authentication with password representing a path to the private key file. There is a downside of overloading vm_password parameter but it also keeps amount of parameters small.

That being said I'm open for adding a new parameter specifically for the private key file.

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@mikhailkoliada mikhailkoliada merged commit a659eb9 into actions:main Apr 9, 2024
3 checks passed
abhijit-hota added a commit to WarpBuilds/runner-images that referenced this pull request Apr 12, 2024
* [Ubuntu] 22.04: install libssl1.1 via apt (actions#9432)

Signed-off-by: You-Sheng Yang <vicamo@gmail.com>

* [Windows] Upgrade php version to 8.3 (actions#9439)

* [macOS] update webservers pester test (actions#9444)

* Updating readme file for win19 version 20240304.2.1 (actions#9453)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* Updating readme file for ubuntu22 version 20240304.1.1 (actions#9450)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu20 version 20240304.1.1 (actions#9451)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Windows] Update Kotlin installer hash check (actions#9469)

* Updating readme file for win22 version 20240304.2.1 (actions#9449)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Ubuntu] Update Kotlin installer hash check (actions#9468)

* [macOS] Remove VCPKG from macOS-14 (actions#9465)

* Add Image Rollout Status badges (actions#9486)

* [macOS]  remove blackhole 2ch (actions#9487)

* [macOS] remove blackhole-2ch

* Update System.Tests.ps1

* [Ubuntu] Update Az to 11.3.1 (actions#9490)

* [windows] Update Az to 11.3.1 (actions#9489)

* [macOS] Add PowerShell version of Configure-Xcode-Simulators script (actions#9496)

* Updating signature for Visual Studio Enterprise 2022.17. (actions#9502)

* [macOS] pin xcbeautify on OS12 (actions#9501)

* Updating readme file for ubuntu20 version 20240310.1.1 (actions#9483)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for win19 version 20240310.1.1 (actions#9485)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu22 version 20240310.1.1 (actions#9482)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Fixed typos (actions#9509)

* Fixed some typos.

* Some more typos.

---------

Co-authored-by: Leon Zandman <lzandman@rdw.nl>

* [macOS] add xcode 15.3 to macOS 13, 14 (actions#9505)

* [macOS] Delete more software from Big Sur (actions#9488)

* Updating readme file for win22 version 20240310.1.1 (actions#9481)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Ubuntu] Decrease vm.mmap_rnd_bit to prevent ASLR ASAN issues (actions#9513)

* Add Xamarin bundle (actions#9514)

* Unpin SYFT tool version for Windows images (actions#9522)

* Unpin SYFT tool version for Windows images

* Update upload-artifact action version to v4

* [MacOS] Add install-python.sh to arm64 templates (actions#9474)

* add install-python.sh to arm64 templates

* add Pipx pester test

* Update Python.Tests.ps1

* bump python version

* Updating readme file for ubuntu22 version 20240317.1.1 (actions#9532)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* Updating readme file for win19 version 20240317.1.1 (actions#9527)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for win22 version 20240317.1.1 (actions#9528)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Update README.md to inccude macOS-latest-xlarge (actions#9541)

* Updating readme file for ubuntu20 version 20240317.1.1 (actions#9531)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-13 version 20240219.1 (actions#9375)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-13-arm64 version 20240219.3 (actions#9374)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [DOCS] remove obsolete debug guide (actions#9548)

* Updating readme file for macos-14-arm64 version 20240219.1 (actions#9380)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* [Ubuntu] remove Docker Comose v1 (actions#9559)

* [Windows] remove Docker Comose v1 (actions#9558)

* [macos13] Remove Xcode 15.3 (actions#9575)

* [Windows] pin zstd to v1.5.5 (actions#9570)

* Updating readme file for win19 version 20240322.1.1 (actions#9556)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu20 version 20240324.1.1 (actions#9561)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu22 version 20240324.2.1 (actions#9560)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [macos] Fix composer version parser (actions#9585)

* [macOS] Force curl to use IPv4 (actions#9586)

* Updating readme file for macos-13 version 20240327.2 (actions#9580)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Windows] Add WIX binaries folder to the PATH (actions#9582)

* [Windows] Add WIX binaries folder to the PATH

* Add Update-Environment, small prettifying

* Move tests from script to Pester

* Fix Wix tests to use Join-Path

---------

Co-authored-by: Leon Zandman <lzandman@github.com>

* Updating readme file for win22 version 20240322.1.1 (actions#9555)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Revert "[Windows] pin zstd to v1.5.5 (actions#9570)" (actions#9589)

This reverts commit f6950e8.

* Updating readme file for macos-14 version 20240325.1 (actions#9578)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [ubuntu] Fix arch in Install-Toolset.ps1 (actions#9598)

* Updating readme file for macos-14-arm64 version 20240325.1 (actions#9579)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Windows] Fix outdated Azure CLI installer signature (actions#9611)

* Update README.md (actions#9601)

macOS 14 GA changes

* [Windows] Force Resolve-ChocoPackageVersion function to use CLI (actions#9605)

* Revert "[Ubuntu] remove Docker Comose v1 (actions#9559)" (actions#9617)

* [Windows] Update docker-compose installation method (actions#9618)

* Updating readme file for macOS-12 version 20240329.1 (actions#9599)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-14 version 20240402.2 (actions#9622)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-14-arm64 version 20240402.2 (actions#9620)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-13 version 20240402.2 (actions#9619)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Revert "[macOS] Force curl to use IPv4 (actions#9586)" (actions#9631)

* Updating readme file for macos-13-arm64 version 20240402.2 (actions#9621)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Update README.md (OS14 latest migration) (actions#9642)

* [MacOS] Fix pipx vars for arm64 (actions#9609)

* fix pipx vars for arm64

* fix white space in path

* Updating readme file for win19 version 20240403.1.1 (actions#9636)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for win22 version 20240403.1.1 (actions#9637)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu20 version 20240407.1.1 (actions#9657)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* Updating readme file for ubuntu22 version 20240407.1.1 (actions#9656)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* Configurable SSH port (actions#9660)

* [Windows] Update Visual Studio 2022 signature (actions#9668)

* Updating readme file for win19 version 20240407.1.1 (actions#9655)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-14 version 20240405.1 (actions#9652)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-13 version 20240405.2 (actions#9651)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for win22 version 20240407.1.1 (actions#9648)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-14-arm64 version 20240405.1 (actions#9653)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* fix swift

* [Ubuntu] Fix Swift installer (actions#9677)

* Updating readme file for macos-13-arm64 version 20240405.1 (actions#9650)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

---------

Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
Co-authored-by: You-Sheng Yang <vicamo@gmail.com>
Co-authored-by: Shivam Mathur <shivam_jpr@hotmail.com>
Co-authored-by: sergei-pyshnoi <121864472+sergei-pyshnoi@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>
Co-authored-by: Erik Bershel <110455084+erik-bershel@users.noreply.github.com>
Co-authored-by: Shamil Mubarakshin <127750046+shamil-mubarakshin@users.noreply.github.com>
Co-authored-by: Mikhail Koliada <88318005+mikhailkoliada@users.noreply.github.com>
Co-authored-by: Alexey-Ayupov <116575425+Alexey-Ayupov@users.noreply.github.com>
Co-authored-by: Piotr Grabski-Gradziński <piotr.gradzinski@gmail.com>
Co-authored-by: Leon Zandman <leon@wirwar.com>
Co-authored-by: Leon Zandman <lzandman@rdw.nl>
Co-authored-by: MaksimZhukov <46996400+MaksimZhukov@users.noreply.github.com>
Co-authored-by: Leon Zandman <lzandman@github.com>
Co-authored-by: Steve-Glass <84886334+Steve-Glass@users.noreply.github.com>
Co-authored-by: Pavel Iakovenko <paveliak@users.noreply.github.com>
guicaulada pushed a commit to grafana/runner-images that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants