[Ubuntu] do not wrap apt-fast in mock script #9794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are wrapping up multiple apt tools into a mock retries script tp avoid race condition caused by apt during images generation. While it works for the most of the tools, for apt-fast it is not, because we are referencing the
/usr/bin
tools into the/usr/local/bin
directory. apt-fast is not the official deb-based bistro tool and never belonged to the/usr/bin
directory (not to say that apt-mocking this tool is pointless as it is not being used during images generation).Previously, apt-fast has been installed into the
/usr/local/sbin
directory, but since recently, upstream has changed its installation destination to the/usr/local/bin
one, in turn, we are cleaning up the/usr/local/bin/apt-fast
file in ourcleanup.sh
script, as we expect it to be a mock alternative of the actual tool, but in reality we are removing the tool from the image entirely. We should not wrap apt-fast anyhow so I propose we stop doing this.Related issue: #9780
Check list