Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu] do not wrap apt-fast in mock script #9794

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

mikhailkoliada
Copy link
Contributor

@mikhailkoliada mikhailkoliada commented May 7, 2024

Description

We are wrapping up multiple apt tools into a mock retries script tp avoid race condition caused by apt during images generation. While it works for the most of the tools, for apt-fast it is not, because we are referencing the /usr/bin tools into the /usr/local/bin directory. apt-fast is not the official deb-based bistro tool and never belonged to the /usr/bin directory (not to say that apt-mocking this tool is pointless as it is not being used during images generation).

Previously, apt-fast has been installed into the /usr/local/sbin directory, but since recently, upstream has changed its installation destination to the /usr/local/bin one, in turn, we are cleaning up the /usr/local/bin/apt-fast file in our cleanup.sh script, as we expect it to be a mock alternative of the actual tool, but in reality we are removing the tool from the image entirely. We should not wrap apt-fast anyhow so I propose we stop doing this.

Related issue: #9780

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@mikhailkoliada
Copy link
Contributor Author

/azp run ubuntu2004,ubuntu2204

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Alexey-Ayupov Alexey-Ayupov merged commit fba8994 into main May 7, 2024
7 checks passed
@Alexey-Ayupov Alexey-Ayupov deleted the fix_apt_fast branch May 7, 2024 08:41
guicaulada pushed a commit to grafana/runner-images that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants