Skip to content

Commit

Permalink
Add an error condition for non jdk Microsoft OpenJDK build (#265)
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitry-shibanov authored Dec 21, 2021
1 parent d23aed3 commit f0bb916
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dist/setup/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13889,6 +13889,9 @@ class MicrosoftDistributions extends base_installer_1.JavaBase {
if (!this.stable) {
throw new Error('Early access versions are not supported');
}
if (this.packageType !== 'jdk') {
throw new Error('Microsoft Build of OpenJDK provides only the `jdk` package type');
}
const availableVersionsRaw = yield this.getAvailableVersions();
const opts = this.getPlatformOption();
const availableVersions = availableVersionsRaw.map(item => ({
Expand Down
11 changes: 11 additions & 0 deletions docs/advanced-usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,17 @@ steps:
- run: java -cp java HelloWorldApp
```

### Microsoft
```yaml
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v2
with:
distribution: 'microsoft'
java-version: '11'
- run: java -cp java HelloWorldApp
```

## Installing custom Java package type
```yaml
steps:
Expand Down
4 changes: 4 additions & 0 deletions src/distributions/microsoft/installer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ export class MicrosoftDistributions extends JavaBase {
throw new Error('Early access versions are not supported');
}

if (this.packageType !== 'jdk') {
throw new Error('Microsoft Build of OpenJDK provides only the `jdk` package type');
}

const availableVersionsRaw = await this.getAvailableVersions();

const opts = this.getPlatformOption();
Expand Down

0 comments on commit f0bb916

Please sign in to comment.