-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The resulting JAVA_HOME_..._architecture variable name is inconsistent: ARM64 or AARCH64 #561
Comments
Hello @vlsi |
Hello @vlsi, |
Hello @vlsi, can you confirm if the above feedback resolves the issue? If not, could you share the issues you are facing? |
Hello @vlsi, just a friendly reminder to confirm if the above feedback resolves the issue. If not, could you please share any issues you are still facing? |
Hello @vlsi, I am closing this issue now. Please feel free to reach out to us if you encounter any other issues. |
Description:
The environment variable name is inconsistent: sometimes it is
JAVA_HOME_17_AARCH64
and sometimes it isJAVA_HOME_17_ARM64
.setup-java/src/distributions/base-installer.ts
Line 172 in 9eda6b5
Task version:
'actions/setup-java@v3' (SHA:0ab4596768b603586c0de567f2430c30f5b0d2b0)
Platform:
Runner type:
Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.
Expected behavior:
The variable name should be consistent.
Preferably, the variable name should use the same values as the action's
architecture
input parameter:setup-java/README.md
Line 36 in 9eda6b5
Actual behavior:
If user omits
architecture
, thensetup-java
generatesJAVA_HOME_17_ARM64
environment variable.If user passes
architecture: aarch64
, thensetup-java
generatesJAVA_HOME_17_AARCH64
variable.The text was updated successfully, but these errors were encountered: