Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting for node-version matrix not working #46

Closed
sondr3 opened this issue Aug 26, 2019 · 5 comments
Closed

Formatting for node-version matrix not working #46

sondr3 opened this issue Aug 26, 2019 · 5 comments

Comments

@sondr3
Copy link

sondr3 commented Aug 26, 2019

I just setup GH Actions using the Nodejs recommended workflow and when using the node-version matrix it doesn't format the name of the version it's using properly:

image

@damccorm
Copy link
Contributor

Could you share your Yaml file? @thboop do you want to take a look at this one?

@thboop
Copy link
Contributor

thboop commented Aug 26, 2019

Hey Sondre, thanks for taking the time to file this issue!
This is related to a ticket I'm working on, I can go ahead and take this item.
It shouldn't be specific to setup-node.

@sondr3
Copy link
Author

sondr3 commented Aug 26, 2019

For what it's worth, here is my nodejs.yml file:

name: Main

on: [push]

jobs:
  run:
    name: Run

    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [10.x, 12.x]

    steps:
    - uses: actions/checkout@v1
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
        
    - name: install and build
      run: |
        npm ci
        npm run build
      env:
        CI: true
 
    - name: lint
      run: |
        npm run lint
        npm run style
            
    - name: test
      run: npm test
      env:
        CI: true

@jaydenseric
Copy link

@chrispat why was this closed?

Here the same issue can be seen: https://github.com/jaydenseric/babel-plugin-syntax-highlight/runs/216262526

@chrispat
Copy link
Member

This issue is fixed in the orchestrator and will rollout in a coming update.

krzyk pushed a commit to krzyk/setup-node that referenced this issue Apr 11, 2023
…-Sandbox-CLI-messaging

Feature/weedocs 2816 update sandbox cli messaging
deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
* adds option to use --signoff with git commit

Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>

* [auto] build: update compiled version

* fix: remove quotes and refactor

* [auto] build: update compiled version

Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants