Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set node-version output (2022 edition) #534

Merged
merged 5 commits into from Jul 4, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Jun 30, 2022

I am unable to update the original PR with a rebase and re-build so I'm opening a new one.

Description:
This adds a node-version output similar to setup-python so that the exact installed node version can be used e.g. as part of a cache key for following build steps.

Related issue:

#150 #173

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@panva panva requested a review from a team as a code owner Jun 30, 2022
@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Jun 30, 2022

Hello @panva. Could you please run npm run build and npm run format commands?

@panva
Copy link
Contributor Author

panva commented Jun 30, 2022

Could you please run npm run build and npm run format commands?

done.

src/main.ts Outdated Show resolved Hide resolved
@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Jun 30, 2022

Could you please revert changes to previous one and add mock for getExecOutput in installer.test.ts ?

    // @actions/exec
    getExecOutputSpy = jest.spyOn(exec, "getExecOutput");
    getExecOutputSpy.mockImplementation(() => "16.15.0");

@panva panva requested a review from dmitry-shibanov Jul 1, 2022
@marko-zivic-93 marko-zivic-93 merged commit 78faa55 into actions:main Jul 4, 2022
110 checks passed
@panva
Copy link
Contributor Author

panva commented Jul 4, 2022

Thank you guiding this through @dmitry-shibanov.

@panva panva mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants