Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes operates on issues/PRs that are already closed #50

Closed
JamesMGreene opened this issue Apr 24, 2020 · 1 comment · Fixed by #52
Closed

Sometimes operates on issues/PRs that are already closed #50

JamesMGreene opened this issue Apr 24, 2020 · 1 comment · Fixed by #52

Comments

@JamesMGreene
Copy link
Contributor

For the "Stale" Probot App, we have received a fair number of reports ([1], [2], [2]) that the app was unexpected operating on issues and PRs that had already been closed. Given that our query to the Issue Search API explicitly included the is:open condition, we determined that this appears to be a more recently introduced bug or shortcoming of the Issue Search API itself -- likely due to outdated indexing.

Luckily, since we are already retrieving the list of issues to be operated on, it was easy enough to add the simple and inexpensive workaround of just checking each issue's state value to verify it was still "open" before processing it.

The same type of workaround should be included in the Stale action as well.

@hross
Copy link
Contributor

hross commented Apr 27, 2020

thanks for the PR and tests. I'll create a new release from master after a few more fixes go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants