Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make not_planned the default close-issue-reason #789

Closed
danielcompton opened this issue Aug 7, 2022 · 4 comments · Fixed by #807
Closed

Make not_planned the default close-issue-reason #789

danielcompton opened this issue Aug 7, 2022 · 4 comments · Fixed by #807
Labels
enhancement New feature or request

Comments

@danielcompton
Copy link

The problem

Currently, everyone who uses actions/stale will need to know to configure the close-issue-reason setting to not_planned to get the new close type - https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

The solution

Make the default value 'not_planned' instead of ''. The reason matches the use in stale - "Won't fix, canceled, duplicate, stale"

@danielcompton danielcompton added the enhancement New feature or request label Aug 7, 2022
david-allison added a commit to david-allison/stale that referenced this issue Sep 5, 2022
GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

'stale' is a use case for this close reason

Fixes actions#789

BREAKING CHANGE:
`close-issue-reason` defaults to `not_planned` (previously: ``
which defaulted to `completed`)
This closes the issue as 'not planned' on GitHub rather than 'completed'

See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
david-allison added a commit to david-allison/stale that referenced this issue Sep 5, 2022
GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

'stale' is a use case for this close reason

Fixes actions#789

BREAKING CHANGE:
`close-issue-reason` defaults to `not_planned` (previously: ``
which defaulted to `completed`)
This closes the issue as 'not planned' on GitHub rather than 'completed'

See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
david-allison added a commit to david-allison/stale that referenced this issue Sep 5, 2022
GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

'stale' is a use case for this close reason

Fixes actions#789

BREAKING CHANGE:
`close-issue-reason` defaults to `not_planned` (previously: ``
which defaulted to `completed`)
This closes the issue as 'not planned' on GitHub rather than 'completed'

See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 7, 2022
@davorpa
Copy link

davorpa commented Sep 7, 2022

bump

It have a current PR fullfilling requirements #807

@github-actions github-actions bot removed the Stale label Sep 8, 2022
david-allison added a commit to david-allison/stale that referenced this issue Sep 14, 2022
GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

'stale' is a use case for this close reason

Fixes actions#789

BREAKING CHANGE:
`close-issue-reason` defaults to `not_planned` (previously: ``
which defaulted to `completed`)
This closes the issue as 'not planned' on GitHub rather than 'completed'

See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
luketomlinson pushed a commit that referenced this issue Sep 20, 2022
)

* docs: add source for default testing options

* fix(options)!: Default to 'Close as not planned'

GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

'stale' is a use case for this close reason

Fixes #789

BREAKING CHANGE:
`close-issue-reason` defaults to `not_planned` (previously: ``
which defaulted to `completed`)
This closes the issue as 'not planned' on GitHub rather than 'completed'

See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
@luketomlinson
Copy link
Collaborator

Released in v6: https://github.com/actions/stale/releases/tag/v6.0.0

@jeffwidman
Copy link

Thanks @luketomlinson 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants