Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): add new option ignore-updates to stale even with activity #540

Merged
merged 27 commits into from
Sep 17, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jul 31, 2021

Changes

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Sep 1, 2021

@luketomlinson any news?

@github-actions github-actions bot removed the Stale label Sep 2, 2021
Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the most part @C0ZEN. My only question is how we name the new options. And while I think these particular new options provide some value, I really want to start limiting the number of new options we add.

__tests__/constants/default-processor-options.ts Outdated Show resolved Hide resolved
@C0ZEN C0ZEN changed the title feat(options): add new option activities-reset-stale to stale even with activity feat(options): add new option ignore-updates to stale even with activity Sep 8, 2021
@peimanja
Copy link

Any update on this? 🙏

Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @C0ZEN 🥇

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Sep 15, 2021

@luketomlinson ready

@luketomlinson luketomlinson merged commit 1cdda06 into actions:main Sep 17, 2021
@C0ZEN C0ZEN deleted the feature/ignore-activity branch September 17, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants