Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow daysBeforeStale options to be float #841

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Allow daysBeforeStale options to be float #841

merged 2 commits into from
Oct 19, 2022

Conversation

irega
Copy link
Contributor

@irega irega commented Oct 7, 2022 •
edited
Loading

Changes

  • Modifies the initialization of the input options daysBeforeStale, daysBeforeIssueStale and daysBeforePrStale to perform a parseFloat instead of parseInt.
  • Adds new test cases to cover the cases where those params are used with hours instead of full days.

Context

Resolves #833

@irega irega marked this pull request as ready for review October 7, 2022 08:30
@irega irega requested a review from a team as a code owner October 7, 2022 08:30
@irega
Copy link
Contributor Author

irega commented Oct 13, 2022

@luketomlinson @rentziass @flaxel @JoannaaKL could you take a look at this PR? 🙏

@JoannaaKL JoannaaKL merged commit 65b52af into actions:main Oct 19, 2022
@irega irega mentioned this pull request Dec 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoannaaKL JoannaaKL JoannaaKL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow daysBeforeStale options to be float
2 participants
@irega @JoannaaKL