Fix stale closing logic by removing close date addition #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to wait to see if I can get some live tests on repos that have stale issues which should be closed before I merge and publish a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closing logic doesn't work because label updates push the updated date on an issue.
I originally added closing days + stale days thinking the
updatedtime wouldn't take the label add into account and because there was a bug where we didn't update the issueupdated_atin memory when we marked it stale.Although there were tests, without the API results its hard to specifically mock all the API edge cases. Existing tests should cover the rest of this fix to make sure there are no regressions.