Use $default-branch token #590
Conversation
|
This doesn't work for me. When I commit this change, the tests no longer trigger at all. Are we supposed to manually replace this with
so it should work? |
This doesn't work for me, the tests don't run at all, despite `master` being the default branch: actions/starter-workflows#590 (comment)
|
@endolith |
|
ohhh, so the workflow is generated from this, not actually a copy of it? |
|
It's a copy, but during the copy process the |
I'm not supposed to copy that directly; it's a template actions/starter-workflows#590 (comment)
|
This is a bit confusing. These "workflow templates" should be clearly labelled as "workflow templates" otherwise people (like me) will copy them and try to use them as is. Is this a repository full of workflows or workflow templates? It seems like we've had the old switcheroo pulled on us here. |
The sentence introducing the requirements before merging has been edited to improve flow
It looks like the $default-branch macro only works in templates, not workflows. This is not explicitly stated anywhere except the linked PR comment. actions/starter-workflows#590 (comment)
Notes: It looks like the $default-branch macro only works in templates, not workflows. This is not explicitly stated anywhere except the linked PR comment. actions/starter-workflows#590 (comment) credit: Gabriel Smith
This updates the existing starter workflows to use the new
$default-branchtoken instead of hard-codedmaster.