[Artifacts] Add tests for E2E artifact upload #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once again failing unit tests are unrelated. See #1488 (comment) |
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
* Add tests for E2E artifact upload * Trigger Build * Extra debug logs * Debug dumping GitHub Context * More logging * Minor cleanup * Trigger Build * Unique artifact name * Fix typo * Fix * Try using github-script * Potential fix * Cleanup * More cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the output of: https://github.com/actions/toolkit/actions/runs/5892906514?pr=1497
Whenever making artifact related changes we want to run upload, list, download end-to-end to make sure we aren't breaking anything.
I've re-enabled
artifact-tests.ymlwhich was disabled once we started working onv2.0.0and these changes now make sure that upload successfully works end to end.In a future PR I plan on calling the list artifacts API to make sure the uploaded artifacts show up successfully