Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Run tests on Node.js v16 as well as v20 #1518

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: Run tests on Node.js v16 as well as v20 #1518

wants to merge 3 commits into from

Conversation

legobeat
Copy link

@legobeat legobeat commented Sep 3, 2023 •
edited
Loading

  • Run build&test job on v16 to check for compatibility breakage
  • Read nodejs versions for other jobs from .nvmrc
  • Add .nvmrc with version set to v20

@legobeat legobeat marked this pull request as ready for review September 3, 2023 02:43
@legobeat legobeat requested a review from a team as a code owner September 3, 2023 02:43
@legobeat legobeat changed the title Ci node version matrix ci: Run tests on Node.js v14 as well as v20 Sep 3, 2023
@legobeat legobeat changed the title ci: Run tests on Node.js v14 as well as v20 ci: Run tests on Node.js v16 as well as v20 Sep 3, 2023
@legobeat legobeat mentioned this pull request Sep 3, 2023
Merged
@legobeat
Copy link
Author

legobeat commented Sep 6, 2023

@takost please take a look, this should be helpful.

@legobeat
Copy link
Author

Rebased on main to resolve merge conflicts from #1652

@legobeat
Copy link
Author

@robherley @eggyhead Would you be able to take a look? 🙏

@eggyhead
Copy link
Contributor

👋 Hi! Thanks for the contribution. I like the idea of introducing an .nvmrc file, but since Node16 is deprecated I don’t see any value in this addition, especially since the CI checks are failing. Could you update to include only the .nvmrc changes or close this PR?

@legobeat
Copy link
Author

legobeat commented Apr 24, 2024 •
edited
Loading

👋 Hi! Thanks for the contribution. I like the idea of introducing an .nvmrc file, but since Node16 is deprecated I don’t see any value in this addition, especially since the CI checks are failing. Could you update to include only the .nvmrc changes or close this PR?

The main motivation with this PR was actually to test on all supported Node.js major versions to avoid unintentional regressions like the one now caught in the test error.

But it sounds like Node.js 16 is not supported by these packages (anymore).

What is the currently supported Node.js version range for these packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kryslynn93 Kryslynn93 Kryslynn93 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @eggyhead @Kryslynn93