Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in github package #1553

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Update dependencies in github package #1553

merged 5 commits into from
Oct 10, 2023

Conversation

takost
Copy link
Contributor

@takost takost commented Oct 9, 2023

Update octokit dependencies in github package.
According to octokit docs to use proxy we need to start using custom fetch function. This functionality was implemented in new @actions/http-client.
As usage of fetch function is new logic, and octokit update has breaking changes, I bumped major version of github package. After this update github package will be able to use only with node>=18

I tested this change with checkout action: actions/checkout#1504

@takost takost requested a review from a team as a code owner October 9, 2023 12:51
Copy link
Member

@rentziass rentziass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants