Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getInput to also support loading from underscored env vars #1659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update getInput to also support loading from underscored env vars #1659

wants to merge 1 commit into from

Conversation

johnandersen777
Copy link

Rather than just hyphens, eases calling from other contexts, such as when testing.

Closes: #629

@pdxjohnny
Update getInput to also support loading from underscored env vars
6cbb8ee 
Rather than just hyphens, eases calling from other contexts,
such as when testing.

Closes: actions#629
@johnandersen777 johnandersen777 marked this pull request as ready for review April 2, 2024 21:19
@johnandersen777 johnandersen777 requested a review from a team as a code owner April 2, 2024 21:19
@rindeal rindeal mentioned this pull request May 23, 2024
Closed
@rindeal
Copy link

rindeal commented Aug 31, 2024 •
edited
Loading

As mentioned in #1740, since the GHA Runner doesn't perform - to _ conversion when setting the INPUT_* environment variables for NodeJS actions, performing this conversion on the client side would prevent those inputs from being read. Any change in this behavior needs to be made solely in the runner code. This PR would break most code in existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvargas92495 dvargas92495 dvargas92495 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inputs with - are hard to test due to shells not supporting env variables with - in the name
4 participants
@johnandersen777 @rindeal @dvargas92495 @pdxjohnny