Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure callback is only called once #1670

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Ensure callback is only called once #1670

merged 2 commits into from
Feb 26, 2024

Conversation

bethanyj28
Copy link
Contributor

We have gotten reports of errors using the latest download-artifact@main:

##[debug]Failed to download artifact after 5 retries due to Callback called multiple times. Retrying in 5 seconds...
Error: Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.
##[debug]response.message: Artifact download failed: Blob storage chunk did not respond in 30000ms
##[debug]response.message: Artifact download failed: Blob storage chunk did not respond in 30000ms
##[debug]response.message: Artifact download failed: Blob storage chunk did not respond in 30000ms
##[debug]response.message: Artifact download failed: Blob storage chunk did not respond in 30000ms
##[debug]response.message: Artifact download failed: Blob storage chunk did not respond in 30000ms
##[debug]Node Action run completed with exit code 1

Given Callback called multiple times it seems like it's attempting to create the directory and calling callback twice. It should only be called once when the file is extracted.

Part of actions/download-artifact#302

@bethanyj28 bethanyj28 marked this pull request as ready for review February 26, 2024 14:47
@bethanyj28 bethanyj28 requested a review from a team as a code owner February 26, 2024 14:47
@bethanyj28 bethanyj28 merged commit 5a7faf0 into main Feb 26, 2024
14 checks passed
@bethanyj28 bethanyj28 deleted the bethanyj28/fix-callback branch February 26, 2024 15:04
@bethanyj28 bethanyj28 mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robherley robherley robherley approved these changes

@rentziass rentziass rentziass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bethanyj28 @rentziass @robherley