(@actions/attest) remove dep on make-fetch-happen #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdehamer
commented
Apr 11, 2024
Comment on lines
-17
to
+16
| const octokit = github.getOctokit(token, {request: {fetch}}) | ||
| const octokit = github.getOctokit(token) |
There was a problem hiding this comment.
This is where we were passing make-fetch-happen into octokit. Now we'll just rely on the default fetch implementation.
bdehamer
force-pushed
the
bdehamer/attest-no-make-fetch-happen
branch
2 times, most recently
from
8b40f08
to
ba904a5
Compare
Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/attest-no-make-fetch-happen
branch
from
ba904a5
to
2961d73
Compare
ejahnGithub
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the dependency on the
make-fetch-happenlibrary.Previously,
make-fetch-happenwas being used as the fetch client to ease the process of mocking requests for the associated unit tests. This PR uses a new approach to mock the interaction with the GH API, so we no longer need this library.