-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GNU tar on macOS if available #701
Conversation
PRs for this is already open and it's focused on support more platforms. |
Yeah, that PR looks pretty messy and incorrect and abandoned. You neglected the fact that This pull request aims to fix exactly 1 problem ( |
You should know that not only Windows, but also all platforms are having problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for putting out this PR.
I'm going to do a little bit more testing before merging this in and then I'll publish a new version of @actions/cache
that can then be used in the our first party action.
I've tested the most obvious edge case a while ago (restore cache saved with bsd tar) and it worked fine: https://github.com/Cyberbeni/install-swift-tool/runs/1456400103#step:4:30 (The workflow later runs the restored binary) |
Published a new release with the changes: https://www.npmjs.com/package/@actions/cache/v/1.0.6 |
As I understant this table: https://github.com/actions/virtual-environments#available-environments
And this comment: actions/runner-images#1534 (comment)
The 20210123 images are the first ones to contain GNU tar and they are at 90%+ rollout progress.
This aims to fix multiple people's issues with caching inside macOS actions:
actions/cache#403
https://github.community/t/bizarre-issue-with-tar-archive-for-macos-build/145377
Cyberbeni/install-swift-tool#69