[Artifacts] Exempt certain types of files from gzip compression #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
…ons#956) * Exempt certain types of files from gzip compression * Fix lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization to speed up artifacts uploads for large files that are already compressed.
See this chart for full implementation details: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/implementation-details.md#uploadcompression-flow
For certain types of files that are already compressed, we basically waste a lot of time creating temporary zips that end up being immediately discarded
Test with 2 800000000 byte (0.75GB) artifacts: 1 min 1second
https://github.com/konradpabjan/artifact-test/runs/4434777033?check_suite_focus=true
Test with existing action, the upload doesn't start until you're 1 min in or so. 2 min 22 seconds total so more than a 50% reduction in time.
https://github.com/konradpabjan/artifact-test/runs/4434790411?check_suite_focus=true