Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: (SqlExecWorkflow) List and Create Module #312

Merged

Conversation

LZS911
Copy link
Collaborator

@LZS911 LZS911 commented May 16, 2024

issue 地址:actiontech/sqle#2429

重构 SQL上线工单的 List 与 Create 模块

放弃了 redux,还是使用了 props 来处理数据流

暂时还没走单元测试。后面补。

重构相关的变更后面会在重构结束后补充文档。修复了一些 bug 以及想要优化一些操作,待和产品沟通确认

assign in @Rain-1214

@Rain-1214
Copy link
Member

我没啥意见。这pipeline要修么?还是合完再修?

@LZS911
Copy link
Collaborator Author

LZS911 commented May 20, 2024

ipeline要修么?还是合完再修?

可以先合并,这个和进去后我开下 detail 部分的 pr。然后再一起处理, detail 部分调整了这个 pr 的部分改动。

@Rain-1214 Rain-1214 merged commit 6aa47e0 into temporary/refactor-order May 21, 2024
0 of 7 checks passed
@Rain-1214 Rain-1214 deleted the refactor/create-sql-exec-workflow branch May 21, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants