-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devise should be a soft dependency #542
Comments
I remember first time I tried it, I slowed my dev server so bad I fell out with my co-developer. We are still fighting even today. The dev server on both our machines is blazingly slow. I sure thought it was devise causing it and suggested to change it to "Sorcery" or make it a very soft dependency or not at all. Well by not at all I mean, require a current_user! of some sort, so anyone can implement there own Auth however they like. REF: #519 Its quick in production though. Just saying. |
Is this being worked on ? |
Not sure. No comments yet from @pcreux. Just thought with the resent release of Warden the authentication would be simplified to allow multiple user types to exist in Rack middleware == warden. Am I even making sense!!! Its late going to bed. |
Nop, this is not being worked on. Feel free to contribute! :) |
I would like to take a shot. Did you have any plan in mind for this? Make it configurable or split that part into a separate gem? (is that possible?) |
So basically,
And I let you see how you can figure out "if the authentication uses devise". :) That's the plan I had in mind. Not sure if it helps. :) |
In my current project I am using sorcery for authentication - a very lightweight solution. I removed all occurrences of devise (configs, routes) and everything works fine - but it would be nice if I could finally uninstall the 'devise' gem :) IMO authentication is not even activeadmin's job and should be fully independent (or maybe as a plugin?). |
This has gotten slightly more annoying recently, since I'm getting these to stderr when my server starts up: [DEVISE] Devise.case_insensitive_keys is false which is no longer supported. If you want to continue running on this mode, please ensure you are not using validatable (you can copy the validations directly to your model) and set case_insensitive_keys to an empty array. [DEVISE] Devise.use_salt_as_remember_token is false which is no longer supported. Devise now only uses the salt as remember token and the remember_token column can be removed from your models. [DEVISE] Devise.reset_password_within is nil. Please set this value to an interval (for example, 6.hours) and add a reset_password_sent_at field to your Devise models (if they don't have one already). |
Yep, same here. |
Also struggling with this. Any news? |
Here's an ugly workaround to at least hide those annoying warnings during server startup. I've put the following lines to the activeadmin-initializer:
That did it for good :D We're using authlogic here, so setting those values should be save (at least for us). |
+1 to this. |
Thank you @toao for geting rid of my pesky error messages for a gem I'm not actually using :-) |
Let's get this done! |
Really i would like to |
how are we on this? |
Load devise only when the dependency is fulfilled. Show an error message when running generator without devise gem. Fixes activeadmin#542.
Load devise only when the dependency is fulfilled. Show an error message when running generator without devise gem. Fixes activeadmin#542.
Load devise only when the dependency is fulfilled. Show an error message when running generator without devise gem. Fixes activeadmin#542.
Load devise only when the dependency is fulfilled. Show an error message when running generator without devise gem. Fixes activeadmin#542.
Load devise only when the dependency is fulfilled. Show an error message when running generator without devise gem. Fixes activeadmin#542.
ActiveAdmin comes from a generator which takes care of setting up a basic authentication mechanism using Devise.
Devise is a depency of ActiveAdmin while it could just be a soft dependency.
This would issues that people encounter when their Rails application uses Warden but not Devise (#178).
See also #519.
The text was updated successfully, but these errors were encountered: