Fix for #2033 - fix the collection_path for 'delete' batch action #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to redirect to the collection path via route_collection_path to ensure that the path will work for nested (belongs_to) resources.
…s the selected rows. * Corrected the tests in the 'Use default (destroy) batch action' scenario in the batch_actions feature.
…th a nested resource.
|
@tinynumbers did you pinpoint what the problem is with |
|
@daxter - Take a look at my comments on #2033 (comment) - I believe this is actually a bug in Inherited Resources (specifically when used with Rails >= 3.2.5), but this pull request will work around that issue until it gets fixed on the Inherited Resources side. |
|
Okay, merging this in. Thanks for the contribution ❤️ |
seanlinsley
added a commit
that referenced
this pull request
Apr 2, 2013
…n-redirect Fix for #2033 - fix the collection_path for 'delete' batch action
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2033 - modify the default "delete" batch action to redirect to the collection path via route_collection_path to ensure that the path will work for nested (belongs_to) resources.