Add Rails 7 Support #7235

tagliala · 2021-12-21T17:39:33Z

Hi, this is a work in progress and I'm opening this PR as a reference to #7196

I'm trying to update activeadmin to use Rails 7, but there are some blocking dependencies:

At the moment, there are no stable JRuby versions supporting MRI 2.7, the minimum required version to run Rails 7.0. There was too much effort in trying to build against jruby-head, so JRuby dependency has been temporarily removed

Test in your application

1. Changes to Gemfile

Add the following to your Gemfile:

gem 'activeadmin', github: 'activeadmin/activeadmin'

Tests

I cannot replicate the zeitwerk failure I see on CI on my local development machine (specs are green)
I have cucumber related failures because of uninitialized constant #<Class:Cucumber::Rails::Database>::NullStrategy (NameError). It is worth to mention that cucumber-rails does seem to work with Rails 7, or at least it does not have specs covering this issue. Ref: Support for Rails 7 cucumber/cucumber-rails#523 (comment)

tagliala · 2021-12-24T12:35:03Z

Updates:

a new version of rails-i18n supporting rails 7 has been released
cucumber features pass on Rails 7 (null database strategy to disable @javascript handling cucumber/cucumber-rails#522 - 7253b1f)
I'm still not able to replicate the spec failure on my development machine or in a linux docker container

| An error occurred while loading ./spec/requests/default_namespace_spec.rb.
| Failure/Error: require "#{ActiveAdmin::TestApplication.new.full_app_dir}/config/environment.rb"
| 
| Zeitwerk::NameError:
|   expected file ~/dev/activeadmin/tmp/test_apps/rails_70/app/admin/admin_users.rb to define constant AdminUsers, but didn't

~~I can replicate this issue locally when I try to run CI workflows using act, but if I login on the docker container and I try there, specs pass. Any hint would help~~

tagliala · 2021-12-24T18:04:42Z

🟢 Specs are green!

I've got the reason of the failure (and - of course - it was pretty simple)

Rails 7's default config/environments/test.rb has the following change:

config.eager_load = ENV["CI"].present?

So Rails 7 is going to perform eager loading and it fails, because remove_active_admin_load_paths_from_rails_autoload_and_eager_load does not prevent eager loading of classes in that folder

I'm not sure of the fix (disable eager loading), please let me know what do you think

tagliala · 2021-12-26T10:25:30Z

UPDATE

Ransack 2.5.0 released, four to go:

arbre (pending release)
cucumber-rails
db-query-matchers (pending merge and release)
inherited_resources (pending release)

Cucumber Rails may need help, there are two conditional test cases to write --> cucumber/cucumber-rails#523

tagliala · 2021-12-30T10:29:27Z

UPDATE 2021-12-30

There is an issue with Rails 7, code reloading, dev environment, and the new server_timing option not detected by specs (because server_timing is only enabled in development environment?)

It is described here: #7196 (comment)

It can be replicated in dev environment by changing something in an activeadmin file (/app/admin/dashboard.rb) and reloading the page

Changing server_timing to false is a workaround, but this issue should be fixed. Any help would be appreciated

Ref: rails/rails@0547b16

rails/rails#36289

UPDATE 2021-12-31

The problem is an incompatibility with the new Server-Timing feature

Server-Timing subscribes to all notifications, and it creates an event by using args. In our case, args is an array of two elements containing ['active_admin.application.before_load', ActiveAdmin::Application], but Event expects five parameters

rails/rails@0547b16#diff-7bae50494146f858329a92e06ec56eb449abff287fc6de733b99b11c589b6c3aR16

I do not know how to fix this

…lish` Fix activeadmin#7235 (comment)

…lish` activeadmin#7235 (comment)

alejandroperea · 2022-01-23T11:48:42Z

@tagliala this PR has been merged #7232. It replaces the db-query-matchers gem with an Rspec matcher that is doing the same check than the gem.

Thanks a lot for your effort!

tagliala · 2022-01-23T12:09:03Z

Hi @alejandroperea, thanks!

I was hoping for #7275 to be merged before rebasing, so I can clean up other things and remove unrelated changes and gem updates

javierjulio · 2022-01-23T16:09:15Z

@tagliala you're good to go as #7275 is merged. I'll approve and run CI here once you push up that update. Thanks again!

deivid-rodriguez

Looks good to me! 🎉

mgrunberg · 2022-03-07T13:40:59Z

@tagliala cucumber-rails 2.5.0 has been released. I created #7369 to upgrade master and tagliala#7 to upgrade this PR in case 7369 reaches master first.

tagliala · 2022-03-07T13:45:59Z

@mgrunberg thanks

I can rebase if #7369 is going to be merged before this one

deivid-rodriguez · 2022-03-07T13:47:36Z

I don't have a preference either way, I'll let @javierjulio choose when he gets to this :)

ghost · 2022-03-07T13:50:42Z

@tagliala Thank you for your efforts getting this updated!

javierjulio · 2022-03-07T14:28:13Z

@tagliala we just merged #7369 so this is ready for rebasing. I'll merge this next. Thank you again! 🙌🏻

- Relax railties dependency to allow 7.0 - Move Rails 6.1 Gemfile to gemfiles directory - Set main test application to Rails 7.0

This method has been removed in Rails 7 and replaced with `constantize`

`ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load` is not working on feature tests. Starting from Rails 7.0, running tests with eager_load enabled produces the following error: ``` Failure/Error: require "#{ActiveAdmin::TestApplication.new.full_app_dir}/config/environment.rb" FrozenError: can't modify frozen Array: ["<root>/tmp/test_apps/rails_70/app/admin", "<root>/tmp/test_apps/rails_70/app/channels", "<root>/tmp/test_apps/rails_70/app/controllers", "<root>/tmp/test_apps/rails_70/app/controllers/concerns", "<root>/tmp/test_apps/rails_70/app/helpers", "<root>/tmp/test_apps/rails_70/app/jobs", "<root>/tmp/test_apps/rails_70/app/mailers", "<root>/tmp/test_apps/rails_70/app/models", "<root>/tmp/test_apps/rails_70/app/models/concerns", "<root>/tmp/test_apps/rails_70/app/policies" ``` `ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load` fails because `ActiveAdmin.application.load_paths` value is `<root>/app/admin` when it should be `<root>/tmp/test_apps/rails_70/app/admin`. `ActiveAdmin::ApplicationSettings` initialize `load_path` with `[File.expand_path("app/admin", Rails.root)]`. On testing app bootstrap ([this line](https://github.com/activeadmin/activeadmin/blob/master/features/support/env.rb#L12)) `Rails.root` is nil and `File.expand_path` is expanding to the folder where `rake test` runs (`<root>`). `ActiveAdmin::Engine` has an initializer to define default value for `load_paths`. The problem is that the block runs after initializers in `config/initializers` folder, including `ActiveAdmin.setup` where `ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load` is called from. This commit makes sure the block runs before `config/initializers`. That way the block sets a proper default.

At the moment of this commit, JRuby does not support Ruby 2.7, the minimum version required to run Rails 7.0, and gems did not install with jruby-head This platform can be added back when JRuby will release a version compatible with 2.7 MRI

tagliala · 2022-03-07T15:12:49Z

Got a segmentation fault on 2.7 vs 6.1. Any chance to restart the build? :\

javierjulio · 2022-03-07T15:17:16Z

Yes I will, thanks for checking it as I was about to ask whether we needed a rebuild or not.

javierjulio

Thank you @tagliala! 🙌🏻❤️

deivid-rodriguez · 2022-03-07T15:40:08Z

Thanks so much @tagliala and @mgrunberg!!

grantspeelman · 2022-03-07T19:13:18Z

Fantastic Work 🥳

dwaynemac · 2022-03-09T22:45:02Z

This is awesome. Thank you very much

christopherdbull · 2022-04-07T15:06:46Z

I've updated to Rails 7 but am getting crashes with uninitialized model constants on the first line of our Admin declarations. Using version 2.11.1, just wondering if you had any hints to debug? Not doing anything fancy with loading as far as I can see, but zeitwerk seems unhappy...

tierra · 2022-04-07T15:21:51Z

Were you using classic mode before? (as that was removed in Rails 7)

Have you checked this?

bin/rails zeitwerk:check

You might want to review the Classic to Zeitwerk HOWTO

Anecdotally, I've finished upgrading my app (using ActiveAdmin) to Rails 7 recently, using this update, and it went smoothly. No issues, and no additional AA changes required, it just worked.

yosiat · 2023-02-07T11:35:23Z

Thanks for adding support for rails 7!

Is it possible to release a version for this PR ?

tagliala · 2023-02-07T11:43:48Z

Hi @yosiat , Rails 7 support has been released in v2.11.0

Changelog: https://github.com/activeadmin/activeadmin/releases/tag/v2.11.0

yosiat · 2023-02-07T12:25:01Z

@tagliala sorry, my mistake!

tagliala mentioned this pull request Dec 21, 2021

Support Rails 7 #7196

Closed

tagliala force-pushed the feature/railties-7 branch 3 times, most recently from 3d78c26 to 7253b1f Compare December 24, 2021 11:39

tagliala force-pushed the feature/railties-7 branch from 7253b1f to d786a97 Compare December 24, 2021 18:01

tagliala force-pushed the feature/railties-7 branch 3 times, most recently from 6791aa9 to 9469604 Compare December 26, 2021 10:22

tagliala force-pushed the feature/railties-7 branch 2 times, most recently from 48fc4ee to 12ef798 Compare December 27, 2021 13:02

This was referenced Dec 29, 2021

Allow Rails 7.0 activeadmin/inherited_resources#707

Merged

Add Active Support 7 support activeadmin/arbre#314

Merged

sprql added a commit to sprql/activeadmin that referenced this pull request Jan 13, 2022

Use instrument from the Notifications API instead of low level `pub…

1c1c794

…lish` Fix activeadmin#7235 (comment)

sprql mentioned this pull request Jan 13, 2022

Use instrument from the Notifications API instead of low level publish #7262

Merged

sprql added a commit to sprql/activeadmin that referenced this pull request Jan 13, 2022

Use instrument from the Notifications API instead of low level `pub…

aea3b89

…lish` activeadmin#7235 (comment)

guillaumebesse mentioned this pull request Jan 14, 2022

[Rails 7] - Help to configure a newly migrated app to process activeadmin assets (js and scss) using jsbundling-rails with esbuild #7264

Closed

Lordnibbler mentioned this pull request Jan 16, 2022

Upgrade to Rails 7.0.1 Lordnibbler/railsblog#171

Merged

7 tasks

tagliala force-pushed the feature/railties-7 branch from 12ef798 to 93b4a3e Compare January 18, 2022 08:40

rafaelfranca closed this in #7262 Jan 19, 2022

rafaelfranca reopened this Jan 19, 2022

tagliala force-pushed the feature/railties-7 branch from 93b4a3e to 8ccc35b Compare January 19, 2022 20:54

deivid-rodriguez mentioned this pull request Jan 20, 2022

Test with Ruby 3.0 and Ruby 3.1 #7275

Merged

tagliala force-pushed the feature/railties-7 branch from 8ccc35b to 3ff80bb Compare January 20, 2022 16:42

tagliala changed the title ~~[Rails 7 WIP] Add Rails 7 Support (missing jruby support)~~ Add Rails 7 Support Mar 5, 2022

tagliala requested a review from deivid-rodriguez March 5, 2022 14:04

tagliala marked this pull request as ready for review March 5, 2022 14:04

deivid-rodriguez approved these changes Mar 7, 2022

View reviewed changes

deivid-rodriguez added the type enhancement label Mar 7, 2022

mgrunberg and others added 5 commits March 7, 2022 15:56

Allow Rails 7.0

ea37380

- Relax railties dependency to allow 7.0 - Move Rails 6.1 Gemfile to gemfiles directory - Set main test application to Rails 7.0

Fix ActiveSupport::Dependencies.costantize

21b98b8

This method has been removed in Rails 7 and replaced with `constantize`

Replace to_s with to_formatted_s

f19f1ac

Remove JRuby platform from Rails 7.0 Gemfile

73ce06e

At the moment of this commit, JRuby does not support Ruby 2.7, the minimum version required to run Rails 7.0, and gems did not install with jruby-head This platform can be added back when JRuby will release a version compatible with 2.7 MRI

tagliala force-pushed the feature/railties-7 branch from 3299528 to 73ce06e Compare March 7, 2022 14:56

javierjulio approved these changes Mar 7, 2022

View reviewed changes

javierjulio merged commit 930f0f1 into activeadmin:master Mar 7, 2022

tagliala deleted the feature/railties-7 branch March 7, 2022 15:41

jgmontoya mentioned this pull request Oct 6, 2023

Support for Rails 7.1 #8090

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Rails 7 Support #7235

Add Rails 7 Support #7235

tagliala commented Dec 21, 2021 •

edited

Loading

tagliala commented Dec 24, 2021 •

edited

Loading

tagliala commented Dec 24, 2021 •

edited

Loading

tagliala commented Dec 26, 2021 •

edited

Loading

tagliala commented Dec 30, 2021 •

edited

Loading

alejandroperea commented Jan 23, 2022

tagliala commented Jan 23, 2022

javierjulio commented Jan 23, 2022

deivid-rodriguez left a comment

mgrunberg commented Mar 7, 2022

tagliala commented Mar 7, 2022

deivid-rodriguez commented Mar 7, 2022

ghost commented Mar 7, 2022

javierjulio commented Mar 7, 2022

tagliala commented Mar 7, 2022

javierjulio commented Mar 7, 2022

javierjulio left a comment

deivid-rodriguez commented Mar 7, 2022

grantspeelman commented Mar 7, 2022

dwaynemac commented Mar 9, 2022

christopherdbull commented Apr 7, 2022

tierra commented Apr 7, 2022

yosiat commented Feb 7, 2023

tagliala commented Feb 7, 2023

yosiat commented Feb 7, 2023

Add Rails 7 Support #7235

Add Rails 7 Support #7235

Conversation

tagliala commented Dec 21, 2021 • edited Loading

✅ No known issues

✅ Dependencies checklist

✅ Removed dependencies

Test in your application

1. Changes to Gemfile

Tests

tagliala commented Dec 24, 2021 • edited Loading

tagliala commented Dec 24, 2021 • edited Loading

🟢 Specs are green!

tagliala commented Dec 26, 2021 • edited Loading

UPDATE

tagliala commented Dec 30, 2021 • edited Loading

UPDATE 2021-12-30

UPDATE 2021-12-31

alejandroperea commented Jan 23, 2022

tagliala commented Jan 23, 2022

javierjulio commented Jan 23, 2022

deivid-rodriguez left a comment

Choose a reason for hiding this comment

mgrunberg commented Mar 7, 2022

tagliala commented Mar 7, 2022

deivid-rodriguez commented Mar 7, 2022

ghost commented Mar 7, 2022

javierjulio commented Mar 7, 2022

tagliala commented Mar 7, 2022

javierjulio commented Mar 7, 2022

javierjulio left a comment

Choose a reason for hiding this comment

deivid-rodriguez commented Mar 7, 2022

grantspeelman commented Mar 7, 2022

dwaynemac commented Mar 9, 2022

christopherdbull commented Apr 7, 2022

tierra commented Apr 7, 2022

yosiat commented Feb 7, 2023

tagliala commented Feb 7, 2023

yosiat commented Feb 7, 2023

tagliala commented Dec 21, 2021 •

edited

Loading

tagliala commented Dec 24, 2021 •

edited

Loading

tagliala commented Dec 24, 2021 •

edited

Loading

tagliala commented Dec 26, 2021 •

edited

Loading

tagliala commented Dec 30, 2021 •

edited

Loading