-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rails 7 #7196
Comments
related #7175 |
I'm trying to update activeadmin to use rails 7 (tagliala#1), but there are some blocking dependencies:
Non-blocking, but downgrade to an older versions without issues:
Non-blocking, but downgrade to an older versions with issues: Check #7235 |
It is not a blocker but in case we are not able to update |
can team update to rubygem ? |
I've updated my comment above by adding arbre, that does not allow 7.0 and so it downgrades to 1.2.1 |
Looks like this branch has issues with the number of args in paginate here https://github.com/activeadmin/activeadmin/blob/master/lib/active_admin/views/components/paginated_collection.rb#L111 |
Thanks, will check edit: I don't know how to replicate (Rails 7.0, Ruby 3.0.3). Is this about pagination in active admin views? This issue will probably be discovered when it will be possible to run specs on activeadmin |
For tracking purposes and to prevent new PRs (edit: I mean new PRs just relaxing the dependency), I opened #7235 |
Hi @tagliala, I'd love to help with the effort to make ActiveAdmin compatible with Rails 7. Is there any piece of the puzzle I can take on? |
Yes, feel free to take a look at #7235, there is a "working" branch with failing specs (on CI) and cucumber features |
Also: - Update bundles - Strengthen jasmine dependency to prevent deprecation errors - Strengthen pry dependency to prevent deprecation errors Close activeadmin#7196
Thank @tagliala adding the above gems does work but whenever we change the code in dev env there is an error afterward, 09:53:56 web.1 | ArgumentError (wrong number of arguments (given 2, expected 5)): We have to restart the server and then all seems to work, any workaround will be appreciated. Plus thank you for your great effort. |
Any chance to provide a step to step guide to reproduce this issue or a reproducible test case in a public repository? |
Sure will share example and steps to produce it today thank you for quick reply. |
No need, reproduced thanks! |
@muaaz-vf could you please try to disable diff --git a/config/environments/development.rb b/config/environments/development.rb
index 62354ff..916e29d 100644
--- a/config/environments/development.rb
+++ b/config/environments/development.rb
@@ -17,7 +17,7 @@ Rails.application.configure do
config.consider_all_requests_local = true
# Enable server timing
- config.server_timing = true
+ # config.server_timing = true
# Enable/disable caching. By default caching is disabled.
# Run rails dev:cache to toggle caching. |
Thank you much appreciated, anyway I can buy you a cup of coffee :) |
Hi @tagliala in my gemfile: gem 'activeadmin', github: 'tagliala/activeadmin', branch: 'feature/railties-7' # FIXME: revert to stable
gem 'arbre', github: 'activeadmin/arbre' # FIXME: remove
gem 'inherited_resources', github: 'activeadmin/inherited_resources' # FIXME: remove and in config/initializers/active_admin.rb ...
config.before_action :abc
... then I got this error:
if I remove config.before_action, it work |
Replicated, thanks edit: This is related to autoloading. I do not know hot to fix, but I've added a checkbox to known issues at #7235 |
Also: - Update bundles - Strengthen jasmine dependency to prevent deprecation warnings - Strengthen pry dependency to prevent deprecation warnings Close activeadmin#7196
Also: - Update bundles - Strengthen jasmine dependency to prevent deprecation warnings - Strengthen pry dependency to prevent deprecation warnings Close activeadmin#7196
Also: - Update bundles - Strengthen jasmine dependency to prevent deprecation warnings - Strengthen pry dependency to prevent deprecation warnings Close activeadmin#7196
@tagliala After much digging, I suspect this is due to the issue mentioned in the callout box here: My app loads OK after wrapping the contents of |
@tagliala Yes I'm not sure there's a fix you can make in the gem(s), but it's a workaround at least for others. It might even go away when we're not loading the inherited resources gem directly, I'm not savvy enough with the exact timing of Rails loading stuff to be able to suggest a permanent fix. One reason I wouldn't suggest baking it in to activeadmin is that by moving the activeadmin setup to In other words, I have this in my AA config:
and I previously had this in my sessions controller:
but I've now had to move that to the end of the
Quite convoluted but hopefully helps other people get going while things are fixed properly. |
@tagliala @deivid-rodriguez Since #7235 was merged yesterday (excellent work!), should we consider ActiveAdmin Rails-7 ready and, if so, release a new version? If not: what's left and where can I find more information about the remaining work? Happy to help. |
I will release a Rails 7 compatible version next Friday. I'll close this issue since it was indeed fixed by #7235! |
Thank you so much for resolving this issue. I have been watching it since December. |
Trying to upgrade to rails 7,
anyone is still facing this problem? |
This issue should have been fixed by #7340 |
That doesn't seem the case here as the error persists even after removing the before_action from the initializer. |
@tagliala I didn't find anything that i can change in my app to mitigate the problem. When the gem is added the error comes from
|
I'm having the exact same issue as @arhaikal using Version 2.13.0. I'm on ruby 2.7.4 / rails 7. UPDATE: |
I'm still getting this error when using |
Probably the problem is in ActiveAdmin::BaseController.send(:include, ActiveAdmin::FiltersPersistance) And it is not related to Rails Admin Please try with ActiveSupport.on_load(:active_admin_controller) do
ActiveAdmin::BaseController.include ActiveAdmin::FiltersPersistance
end Ref: #7340 |
@tagliala Thanks, that fixed it |
@tagliala , @ALL I upgraded my rails version from 6.1 to 7 but facing the following issue related to activeadmin.
|
@ghulamjilani mai depend on other gems, please check the latest comments in this thread and #7340
The proper solution should involve |
Can't install activeadmin using rails 7.0.0.alpha2, please help
Logs
The text was updated successfully, but these errors were encountered: