You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling this method with a valid / retriable message ID results in a Jackson exception because response is now a JSON-encoded Object, not just a String value. It seems sane to keep the return type as String, by decoding the JSON response to BaseMessageResponse.class and returning the String value.
bypassInboundMessage() also should be updated -- and some of the other methods that return a generic HashMap seem like also using the BaseMessageResponse there might be a better choice (since they're also getting the Integer ErrorCode, String Message response) -- in which case returning BaseMessageResponse rather than BaseMessageResponse.getMessage() might be best.
we just released new version 1.5.5 which should be available by maven in couple of minutes, which resolves this issue and adds new endpoints to the library.
One specific example:
Calling this method with a valid / retriable message ID results in a Jackson exception because
response
is now a JSON-encoded Object, not just a String value. It seems sane to keep the return type asString
, by decoding the JSON response toBaseMessageResponse.class
and returning the String value.bypassInboundMessage()
also should be updated -- and some of the other methods that return a generic HashMap seem like also using the BaseMessageResponse there might be a better choice (since they're also getting the Integer ErrorCode, String Message response) -- in which case returningBaseMessageResponse
rather thanBaseMessageResponse.getMessage()
might be best.I've added a PR, #21, in case that's of any help.
The text was updated successfully, but these errors were encountered: